Fix PaperBench rubric pruning at subtree boundaries - #160
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Fix PaperBench rubric pruning at subtree boundaries#160sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Subtreetask category when pruning an internal rubric node into a leafTaskNoderequires every leaf to have a task category and every internal node to have no task category.prune_to_depth()currently copiesself.task_categorywhen replacing a node with a leaf. For an internal node that value is necessarilyNone, so pruning at the requested depth raisesValueErrorinstead of producing a pruned tree.Subtreeis already a supported category used for approximate subtree grading, so it is the natural category for a collapsed internal node.Regression coverage prunes an internal root at depth zero and verifies it becomes a valid
Subtreeleaf.